From 916bee0dfca74984d64b653eed3bbb814858af07 Mon Sep 17 00:00:00 2001 From: bakonpancakz Date: Thu, 28 May 2026 10:21:56 -0700 Subject: [PATCH] bugfix: Proper permissions These were too open beforehand --- backend/routes/POST_Uploads.go | 8 ++++---- backend/tools/util_configuration.go | 10 ++++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/backend/routes/POST_Uploads.go b/backend/routes/POST_Uploads.go index 436a56f..bc3102f 100644 --- a/backend/routes/POST_Uploads.go +++ b/backend/routes/POST_Uploads.go @@ -138,7 +138,7 @@ func POST_Uploads(w http.ResponseWriter, r *http.Request) { // --- Create Temporary Files --- flags := os.O_CREATE | os.O_TRUNC | os.O_WRONLY - if f, err := os.OpenFile(PathUpload, flags, tools.FILE_PUBLIC); err != nil { + if f, err := os.OpenFile(PathUpload, flags, tools.FS_FILE_PUBLIC); err != nil { sse.SendServerError(err) return } else { @@ -147,7 +147,7 @@ func POST_Uploads(w http.ResponseWriter, r *http.Request) { defer f.Close() } - if f, err := os.OpenFile(PathLogger, flags, tools.FILE_PRIVATE); err != nil { + if f, err := os.OpenFile(PathLogger, flags, tools.FS_FILE_PRIVATE); err != nil { sse.SendServerError(err) return } else { @@ -626,7 +626,7 @@ func POST_Uploads(w http.ResponseWriter, r *http.Request) { ) // --- Create Directory --- - if err := os.MkdirAll(TargetDir, tools.FILE_PUBLIC); err != nil { + if err := os.MkdirAll(TargetDir, tools.FS_DIR_PUBLIC); err != nil { sse.SendServerError(err) return } @@ -661,7 +661,7 @@ func POST_Uploads(w http.ResponseWriter, r *http.Request) { } defer s.Close() - t, err := os.OpenFile(op.PathTarget, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, tools.FILE_PUBLIC) + t, err := os.OpenFile(op.PathTarget, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, tools.FS_FILE_PUBLIC) if err != nil { sse.SendServerError(err) return diff --git a/backend/tools/util_configuration.go b/backend/tools/util_configuration.go index d443583..b722e0f 100644 --- a/backend/tools/util_configuration.go +++ b/backend/tools/util_configuration.go @@ -18,8 +18,10 @@ const ( SNOWFLAKE_EPOCH_SECONDS = SNOWFLAKE_EPOCH_MILLI / 1000 // Apr 1st 2008 (Teto B-Day!) TIMEOUT_SHUTDOWN = 1 * time.Minute // Standard Timeout for Shutdowns TIMEOUT_CONTEXT = 10 * time.Second // Standard Timeout for Requests - FILE_PUBLIC = os.FileMode(0770) // rwxrwx--- - FILE_PRIVATE = os.FileMode(0700) // rwx------ + FS_FILE_PUBLIC = os.FileMode(0640) // rw-r----- + FS_FILE_PRIVATE = os.FileMode(0600) // rw------- + FS_DIR_PUBLIC = os.FileMode(0750) // rwxr-x--- + FS_DIR_PRIVATE = os.FileMode(0700) // rwx------ ) var ( @@ -59,11 +61,11 @@ var ( func init() { // Prepare Directories - if err := os.MkdirAll(STORAGE_DISK_PUBLIC, FILE_PUBLIC); err != nil { + if err := os.MkdirAll(STORAGE_DISK_PUBLIC, FS_DIR_PUBLIC); err != nil { LoggerInit.Log(FATAL, "Cannot Create Public Directory") return } - if err := os.MkdirAll(STORAGE_DISK_TEMP, FILE_PUBLIC); err != nil { + if err := os.MkdirAll(STORAGE_DISK_TEMP, FS_DIR_PRIVATE); err != nil { LoggerInit.Log(FATAL, "Cannot Create Temp Directory") return }